light7734/light
light7734/light
1
1
Fork 0
Code Issues 21 Pull requests 3 Projects 1 Releases Packages Wiki Activity

ci(amd64/clang/lsan): fix leak sanitizer errors #57

Merged
light7734 merged 35 commits from ci/leak_sanatizer_fix into main 2025-10-09 14:08:14 +00:00
Conversation 0 Commits 35 Files changed 15 +9 -8
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit de2a7f7e14 - Show all commits

10
modules/renderer/private/backend/vk/context/instance.cpp
View file

@ -231,10 +231,10 @@ void Instance::initialize_instance()
void Instance::load_library() void Instance::load_library()
{ {
library = dlopen("libvulkan.so.1", RTLD_NOW | RTLD_LOCAL); library = dlopen("libvulkan.so.1", RTLD_NOW | RTLD_GLOBAL | RTLD_NODELETE);
if(!library) if (!library)
{ {
library = dlopen("libvulkan.so", RTLD_NOW | RTLD_LOCAL | RTLD_NODELETE); library = dlopen("libvulkan.so", RTLD_NOW | RTLD_GLOBAL | RTLD_NODELETE);
} }
ensure(library, "Failed to dlopen vulkan library"); ensure(library, "Failed to dlopen vulkan library");
@ -256,8 +256,8 @@ void Instance::unload_library()
// eg. https://github.com/google/sanitizers/issues/89 // eg. https://github.com/google/sanitizers/issues/89
// with no noticable gains, so we just don't bother closing it. // with no noticable gains, so we just don't bother closing it.
// dlclose(library); dlclose(library);
// library = nullptr; library = nullptr;
} }
void Instance::load_global_functions() void Instance::load_global_functions()

3
tools/ci/amd64/clang/lsan.sh
View file

@ -17,6 +17,7 @@ cmake . \
-DCMAKE_BUILD_TYPE=Debug \ -DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS=" \ -DCMAKE_CXX_FLAGS=" \
-fsanitize=leak \ -fsanitize=leak \
-fno-common \
-g \ -g \
-fno-omit-frame-pointer \ -fno-omit-frame-pointer \
-std=c++23 \ -std=c++23 \
@ -30,7 +31,7 @@ cmake . \
-Wl,-rpath,/libcxx_lsan/lib" \ -Wl,-rpath,/libcxx_lsan/lib" \
&& cmake --build ./build -j`nproc` && cmake --build ./build -j`nproc`
export LSAN_OPTIONS="suppressions=$(git rev-parse --show-toplevel)/tools/ci/amd64/clang/lsan.supp:fast_unwind_on_malloc=0" export LSAN_OPTIONS="suppressions=$(git rev-parse --show-toplevel)/tools/ci/amd64/clang/lsan.supp:fast_unwind_on_malloc=0:verbosity=1:report_objects=1"
export LSAN_SYMBOLIZER_PATH="$(which llvm-symbolizer)" export LSAN_SYMBOLIZER_PATH="$(which llvm-symbolizer)"
for test in $(find ./build -type f -name '*_tests' -executable); do for test in $(find ./build -type f -name '*_tests' -executable); do
echo "Running $test" echo "Running $test"