modules/CMakeLists.txt

@@ -5,8 +5,8 @@ add_subdirectory(./logger)
 add_subdirectory(./debug)
 add_subdirectory(./math)
 # 
-# add_subdirectory(./asset_baker)
-# add_subdirectory(./asset_parser)
+add_subdirectory(./asset_baker)
+add_subdirectory(./asset_parser)
 # add_subdirectory(./asset_manager)
 # 
 add_subdirectory(./camera)

modules/ecs/private/registry.test.cpp

@@ -8,6 +8,8 @@ using lt::test::expect_unreachable;
 using lt::test::Suite;
 
 using lt::test::expect_eq;
+using lt::test::expect_ne;
+using lt::test::expect_throw;
 
 using lt::test::expect_false;
 using lt::test::expect_true;
@@ -17,7 +19,7 @@ using lt::ecs::Registry;
 
 struct Component
 {
-	int m_int {};
+	int m_int;
 	std::string m_string;
 
 	[[nodiscard]] friend auto operator==(const Component &lhs, const Component &rhs) -> bool
@@ -41,7 +43,7 @@ struct std::formatter<Component>
 
 struct Component_B
 {
-	float m_float {};
+	float m_float;
 
 	[[nodiscard]] friend auto operator==(const Component_B lhs, const Component_B &rhs) -> bool
 	{

modules/ecs/public/registry.hpp

@@ -6,8 +6,6 @@ namespace lt::ecs {
 
 using Entity = uint32_t;
 
-constexpr auto null_entity = std::numeric_limits<Entity>::max();
-
 /** A registry of components, the heart of an ECS architecture.
  *
  * @todo(Light): Implement grouping

modules/ecs/public/sparse_set.hpp

@@ -150,11 +150,6 @@ public:
 		return m_sparse.capacity();
 	}
 
-	[[nodiscard]] auto is_empty() const noexcept -> bool
-	{
-		return m_dense.empty();
-	}
-
 private:
 	std::vector<Dense_T> m_dense;
 

modules/logger/public/logger.hpp

@@ -35,13 +35,13 @@ public:
 	void static show_imgui_window();
 
 	template<typename... Args>
-	void static log(LogLvl lvl, std::format_string<Args...> fmt, Args &&...args) noexcept
+	void static log(LogLvl lvl, std::format_string<Args...> fmt, Args &&...args)
 	{
 		std::ignore = lvl;
 		std::println(fmt, std::forward<Args>(args)...);
 	}
 
-	void static log(LogLvl lvl, const char *message) noexcept
+	void static log(LogLvl lvl, const char *message)
 	{
 		std::ignore = lvl;
 		std::println("{}", message);
@@ -53,37 +53,37 @@ private:
 };
 
 template<typename... Args>
-void log_trc(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_trc(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::trace, fmt, std::forward<Args>(args)...);
 }
 
 template<typename... Args>
-void log_dbg(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_dbg(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::debug, fmt, std::forward<Args>(args)...);
 }
 
 template<typename... Args>
-void log_inf(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_inf(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::info, fmt, std::forward<Args>(args)...);
 }
 
 template<typename... Args>
-void log_wrn(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_wrn(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::warn, fmt, std::forward<Args>(args)...);
 }
 
 template<typename... Args>
-void log_err(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_err(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::error, fmt, std::forward<Args>(args)...);
 }
 
 template<typename... Args>
-void log_crt(std::format_string<Args...> fmt, Args &&...args) noexcept
+void log_crt(std::format_string<Args...> fmt, Args &&...args)
 {
 	Logger::log(LogLvl::critical, fmt, std::forward<Args>(args)...);
 }

modules/mirror/private/entrypoint/mirror.cpp

@@ -201,7 +201,7 @@ private:
 
 	Ref<MirrorSystem> m_mirror_system;
 
-	lt::ecs::Entity m_window = lt::ecs::null_entity;
+	lt::ecs::Entity m_window;
 };
 
 auto app::create_application() -> Scope<app::Application>

modules/surface/private/linux/system.cpp

@@ -58,28 +58,20 @@ System::System(Ref<ecs::Registry> registry): m_registry(std::move(registry))
 
 System::~System()
 {
-	try
+	// TODO(Light): make registry.remove not validate iterators
+	auto entities_to_remove = std::vector<ecs::Entity> {};
+	for (auto &[entity, surface] : m_registry->view<SurfaceComponent>())
 	{
-		// TODO(Light): make registry.remove not validate iterators
-		auto entities_to_remove = std::vector<ecs::Entity> {};
-		for (auto &[entity, surface] : m_registry->view<SurfaceComponent>())
-		{
-			entities_to_remove.emplace_back(entity);
-		}
-
-		for (auto entity : entities_to_remove)
-		{
-			m_registry->remove<SurfaceComponent>(entity);
-		}
-
-		m_registry->disconnect_on_construct<SurfaceComponent>();
-		m_registry->disconnect_on_destruct<SurfaceComponent>();
+		entities_to_remove.emplace_back(entity);
 	}
-	catch (const std::exception &exp)
+
+	for (auto entity : entities_to_remove)
 	{
-		log_err("Uncaught exception in surface::~System:");
-		log_err("\twhat: {}", exp.what());
+		m_registry->remove<SurfaceComponent>(entity);
 	}
+
+	m_registry->disconnect_on_construct<SurfaceComponent>();
+	m_registry->disconnect_on_destruct<SurfaceComponent>();
 }
 
 void System::on_register()
@@ -149,8 +141,8 @@ void System::on_surface_construct(ecs::Registry &registry, ecs::Entity entity)
 		XSetWMProtocols(display, main_window, &surface.m_native_data.wm_delete_message, 1);
 
 		// code to remove decoration
-		auto hints = std::array<unsigned char, 5> { 2, 0, 0, 0, 0 };
-		const auto motif_hints = XInternAtom(display, "_MOTIF_WM_HINTS", False);
+		long hints[5] = { 2, 0, 0, 0, 0 };
+		Atom motif_hints = XInternAtom(display, "_MOTIF_WM_HINTS", False);
 
 		XChangeProperty(
 		    display,
@@ -159,7 +151,7 @@ void System::on_surface_construct(ecs::Registry &registry, ecs::Entity entity)
 		    motif_hints,
 		    32,
 		    PropModeReplace,
-		    hints.data(),
+		    (unsigned char *)&hints,
 		    5
 		);
 
@@ -291,7 +283,28 @@ void System::handle_events(SurfaceComponent &surface)
 			break;
 		}
 
-		default: break; /* pass */
+		case Expose: break;
+		case GraphicsExpose: break;
+		case NoExpose: break;
+		case CirculateRequest: break;
+		case ConfigureRequest: break;
+		case MapRequest: break;
+		case ResizeRequest: break;
+		case CirculateNotify: break;
+		case CreateNotify: break;
+		case DestroyNotify: break;
+		case GravityNotify: break;
+		case MapNotify: break;
+		case MappingNotify: break;
+		case ReparentNotify: break;
+		case UnmapNotify: break;
+		case VisibilityNotify: break;
+		case ColormapNotify: break;
+		case PropertyNotify: break;
+		case SelectionClear: break;
+		case SelectionNotify: break;
+		case SelectionRequest: break;
+		default: log_inf("Unknown X Event");
 		}
 	}
 }

modules/surface/private/system.fuzz.cpp

@@ -47,9 +47,7 @@ void create_surface_component(test::FuzzDataProvider &provider, ecs::Registry &r
 
 	try
 	{
-		auto entity = registry.create_entity();
-		registry.add<surface::SurfaceComponent>(
-		    entity,
+		registry.create_entity("").add_component<surface::SurfaceComponent>(
 		    surface::SurfaceComponent::CreateInfo {
 		        .title = std::move(title),
 		        .resolution = resolution,
@@ -66,11 +64,11 @@ void create_surface_component(test::FuzzDataProvider &provider, ecs::Registry &r
 
 void remove_surface_component(ecs::Registry &registry)
 {
-	const auto view = registry.view<SurfaceComponent>();
+	const auto view = registry.get_entt_registry().view<SurfaceComponent>();
 
-	if (!view.is_empty())
+	if (!view->empty())
 	{
-		registry.remove<SurfaceComponent>(view[0].first);
+		registry.get_entt_registry().remove<SurfaceComponent>(*view.begin());
 	}
 }
 
@@ -104,7 +102,8 @@ test::FuzzHarness harness = [](const uint8_t *data, size_t size) {
 		case FuzzAction::create_entity:
 		{
 			const auto length = std::min(provider.consume<uint32_t>().value_or(16), 255u);
-			registry->create_entity();
+			const auto tag = provider.consume_string(length).value_or("");
+			registry->create_entity(tag);
 
 			break;
 		}
@@ -120,15 +119,15 @@ test::FuzzHarness harness = [](const uint8_t *data, size_t size) {
 		}
 		case FuzzAction::push_event:
 		{
-			auto view = registry->view<SurfaceComponent>();
+			const auto view = registry->get_entt_registry().view<SurfaceComponent>();
 
-			if (!view.is_empty())
+			if (!view->empty())
 			{
-				for (auto &[entity, component] : view)
-				{
+				view.each([&](auto entity, SurfaceComponent &surface) {
 					provider.consume<uint8_t>().value_or(0);
-					// @TODO(Light): push some event
-				}
+				});
+
+				registry->get_entt_registry().remove<SurfaceComponent>(*view.begin());
 			}
 
 			break;
@@ -137,7 +136,6 @@ test::FuzzHarness harness = [](const uint8_t *data, size_t size) {
 		{
 			break;
 		}
-		case FuzzAction::count:
 		case FuzzAction::tick_system:
 		{
 			system.tick();

tools/ci/amd64/gcc/unit_tests.sh

@@ -2,7 +2,8 @@
 
 set -e
 cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/ && cd build
+rm -rf ./build
+mkdir build/ && cd build
 
 Xvfb :99 -screen 0 1024x768x16 &
 export CXX=$(which g++)

tools/ci/static_analysis/clang_format.dockerfile

@@ -0,0 +1,9 @@
+FROM alpine:latest
+
+RUN apk add --no-cache \
+    bash \
+    curl \
+    findutils \
+    git \
+    libc6-compat \
+    clang-extra-tools 

tools/ci/static_analysis/clang_tidy.dockerfile

@@ -0,0 +1,42 @@
+FROM alpine:latest
+
+RUN apk add --no-cache \
+    bash \
+    clang \
+    llvm \
+    cmake \
+    git \
+    make \
+    g++ \
+    python3 \
+    py3-pip \
+    mesa-dev \
+    mesa-gl \
+    pkgconf \
+    clang-extra-tools \
+    mold \
+    ninja
+
+RUN pip install --no-cache-dir --break-system-packages conan gitpython \
+    && conan profile detect
+
+RUN clang --version  \
+    && conan --version \
+    && pip --version \
+    && cmake --version \
+    && g++ --version \
+    && clang --version \
+    && clang-tidy --version \
+    && ninja --version \
+    && mold --version
+
+
+RUN git clone 'https://git.light7734.com/light7734/light.git' \
+    && cd light \
+    && conan install . \
+        -c tools.system.package_manager:mode=install \
+        -c tools.cmake.cmaketoolchain:generator=Ninja \
+        -s build_type=Release \
+        -o enable_static_analysis=True \
+        -o use_mold=True \
+        --build=missing

tools/ci/static_analysis/clang_tidy.sh

@@ -2,16 +2,19 @@
 
 set -e
 cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/ && cd build
+rm -rf ./build
 
-export CC=$(which clang)
-export CXX=$(which clang++)
+echo 'Static analysis is currently disabled as code is filled with failing clang-tidy checks'
+echo 'Runng this would be a waste of CPU cycles and electricty'
+echo 'Fix the checks before removing these lines'
+exit 0
 
 cmake .. \
 -G Ninja \
 -DCMAKE_LINKER_TYPE=MOLD \
 -DENABLE_UNIT_TESTS=ON \
--DENABLE_STATIC_ANALYSIS=ON \
+-DENABLE_FUZZ_TESTS=ON \
+-CMAKE_CXX_CLANG_TIDY=ON \
 -DCMAKE_BUILD_TYPE=Release \
--DCMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++" \
+-DCMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++ -g -fno-omit-frame-pointer" \
 && cmake --build . -j `nproc`