refactor(ci): fix shellcheck analysis

tools/ci/amd64/build.log

@@ -1,49 +0,0 @@
-#0 building with "default" instance using docker driver
-
-#1 [internal] load build definition from Dockerfile
-#1 transferring dockerfile: 7.49kB done
-#1 DONE 0.0s
-
-#2 [internal] load metadata for docker.io/library/archlinux:latest
-#2 DONE 1.7s
-
-#3 [internal] load .dockerignore
-#3 transferring context: 2B done
-#3 DONE 0.0s
-
-#4 [ 1/12] FROM docker.io/library/archlinux:latest@sha256:287bf95d97e4f952a94a1f4a83008c6a547405bacc44173bda151231a3c843aa
-#4 DONE 0.0s
-
-#5 [ 4/12] RUN git clone     --branch llvmorg-20.1.8     --depth=1     https://github.com/llvm/llvm-project.git
-#5 CACHED
-
-#6 [ 9/12] RUN tar xf vulkansdk-linux-x86_64-1.4.328.1.tar.xz
-#6 CACHED
-
-#7 [ 5/12] RUN cd llvm-project/ && cmake     -S ./runtimes     -B ./build-lsan     -G Ninja     -D CMAKE_LINKER_TYPE="MOLD"     -D CMAKE_BUILD_TYPE=Release     -D CMAKE_INSTALL_PREFIX=/libcxx_lsan     -D CMAKE_C_COMPILER=$(which clang)     -D CMAKE_CXX_COMPILER=$(which clang++)     -D LLVM_ENABLE_PROJECTS="clang;compiler-rt"     -D LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"     -D LLVM_ENABLE_PIC=ON     -D LIBCXX_INSTALL_MODULES=ON     -D LIBCXXABI_USE_LLVM_UNWINDER=OFF     -D LLVM_USE_SANITIZER=Leaks && cd ./build-lsan/ && ninja cxx cxxabi && ninja install-cxx install-cxxabi && cd ../ && cmake     -S ./runtimes     -B ./build-msan     -G Ninja     -D CMAKE_LINKER_TYPE="MOLD"     -D CMAKE_BUILD_TYPE=Release     -D CMAKE_INSTALL_PREFIX=/libcxx_msan     -D CMAKE_C_COMPILER=$(which clang)     -D CMAKE_CXX_COMPILER=$(which clang++)     -D LLVM_ENABLE_PROJECTS="clang;compiler-rt"     -D LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"     -D LLVM_ENABLE_PIC=ON     -D LIBCXX_INSTALL_MODULES=ON     -D LIBCXXABI_USE_LLVM_UNWINDER=OFF     -D LLVM_USE_SANITIZER=MemoryWithOrigins && cd ./build-msan/ && ninja cxx cxxabi && ninja install-cxx install-cxxabi && cd ../ && cd ../ && rm -rf llvm-project
-#7 CACHED
-
-#8 [ 7/12] RUN wget https://x.org/releases/individual/lib/libX11-1.8.12.tar.xz  && tar xf libX11-1.8.12.tar.xz  && cd libX11-1.8.12  && export CC=clang && export CFLAGS=" -fsanitize=memory -fsanitize-memory-track-origins -fsanitize-ignorelist=/msan/ignorelist_all_sources -fno-omit-frame-pointer -g -fPIC" && export LDFLAGS=" -fsanitize=memory -fsanitize-memory-track-origins -fsanitize-ignorelist=/msan/ignorelist_all_sources -fno-omit-frame-pointer -g -fPIC" && export PKG_CONFIG_PATH=/msan/lib/pkgconfig:$PKG_CONFIG_PATH && ./configure     --prefix=/msan     --disable-static && make && make install && cd .. && rm -rf libX11-1.8.12 libX11-1.8.12.tar.xz
-#8 CACHED
-
-#9 [ 8/12] RUN wget 'https://sdk.lunarg.com/sdk/download/1.4.328.1/linux/vulkansdk-linux-x86_64-1.4.328.1.tar.xz'
-#9 CACHED
-
-#10 [ 2/12] RUN mkdir /msan && echo 'src:*' > /msan/ignorelist_all_sources && sed -i 's/^#ParallelDownloads = .*/ParallelDownloads = 8/' /etc/pacman.conf && echo 'NoExtract = usr/share/{man,doc,info}/*' >> /etc/pacman.conf
-#10 CACHED
-
-#11 [ 3/12] RUN pacman -Syyu --noconfirm --needed --disable-download-timeout     afl++     afl-utils     base-devel     bash     cbindgen     clang     cmake     curl     debuginfod     directx-headers     elfutils     expat     gcc     gcc-libs     gdb     git     glibc     glm     glslang     libc++     libclc     libdrm     libelf     libglvnd     libinput     libpciaccess     libpng     libunwind     libva     libx11     libxcb     libxdamage     libxext     libxfixes     libxi     libxinerama     libxml2     libxpresent     libxrandr     libxshmfence     libxxf86vm     lm_sensors     llvm     lz4     meson     mold     ninja     python     python-distlib     python-distutils-extra     python-jsonschema     python-mako     python-packaging     python-ply     python-pyaml     qt5-base     qt6-base     rust     rust-bindgen     spirv-llvm-translator     spirv-tools     systemd-libs     valgrind     vulkan-headers     vulkan-icd-loader     vulkan-tools     vulkan-validation-layers     wayland     wayland-protocols     wget     xcb-proto     xcb-util     xcb-util-cursor     xcb-util-keysyms     xcb-util-wm     xorg-server-xvfb     xorg-util-macros     xorgproto     xtrans     zlib     zstd && pacman -Scc --noconfirm
-#11 CACHED
-
-#12 [10/12] RUN cd /1.4.328.1 && chmod +x ./vulkansdk && chmod +x ./setup-env.sh && export CC="$(which clang)" && export CXX="$(which clang++)" && export CXXFLAGS="        -fsanitize=memory         -fsanitize-memory-track-origins         -fsanitize-ignorelist=/msan/ignorelist_all_sources         -fno-omit-frame-pointer         -g         -std=c++23         -nostdinc++         -isystem /libcxx_msan/include/c++/v1/"&& export CFLAGS="        -fsanitize=memory         -fsanitize-memory-track-origins         -fno-omit-frame-pointer         -g" && export LDFLAGS="    -fsanitize=memory     -fsanitize-memory-track-origins     -fsanitize-ignorelist=/msan/ignorelist_all_sources     -g     -std=c++23     -L/msan/lib -Wl,-rpath,/msan/lib     -L/libcxx_msan/lib -Wl,-rpath,/libcxx_msan/lib     -lc++     -lc++abi" && ./vulkansdk     --debug     --numjobs `nproc`     vulkan-loader
-#12 CACHED
-
-#13 [ 6/12] RUN wget https://x.org/releases/individual/lib/libxcb-1.17.0.tar.xz  && tar xf libxcb-1.17.0.tar.xz  && cd libxcb-1.17.0  && export CC=clang && export CFLAGS="     -fsanitize=memory     -fsanitize-memory-track-origins     -fsanitize-ignorelist=/msan/ignorelist_all_sources     -fno-omit-frame-pointer     -g     -fPIC" && export LDFLAGS="     -fsanitize=memory     -fsanitize-memory-track-origins     -fsanitize-ignorelist=/msan/ignorelist_all_sources     -fno-omit-frame-pointer     -g     -fPIC" && ./configure     --prefix=/msan     --disable-static     --without-doxygen && make && make install && cd .. && rm -rf libxcb-1.17.0 libxcb-1.17.0.tar.xz
-#13 CACHED
-
-#14 [11/12] RUN git clone     --branch='25.2'    --depth=1     https://gitlab.freedesktop.org/mesa/mesa.git
-#14 CACHED
-
-#15 [12/12] RUN cd mesa/ && mkdir _build && export CXX=$(which clang++) && export CC=$(which clang) && export CXXFLAGS="        -fsanitize=memory         -fsanitize-memory-track-origins         -fno-omit-frame-pointer         -g         -std=c++23         -nostdinc++         -isystem /libcxx_msan/include/c++/v1/"&& export CFLAGS="        -fsanitize=memory         -fsanitize-memory-track-origins         -fno-omit-frame-pointer         -g" && export LDFLAGS="    -fsanitize=memory     -fsanitize-memory-track-origins     -g     -L/msan/lib -Wl,-rpath,/msan/lib     -L/libcxx_msan/lib -Wl,-rpath,/libcxx_msan/lib     -lc++     -lc++abi" && meson setup ./ _build      -D android-libbacktrace=disabled     -D b_ndebug=false     -D b_lto=false     -D egl=enabled     -D gallium-drivers=r300,r600,radeonsi,nouveau,virgl,svga,softpipe,llvmpipe,i915,iris,crocus,zink     -D gallium-extra-hud=true     -D gallium-rusticl=true     -D gallium-va=enabled     -D gbm=enabled     -D gles1=disabled     -D gles2=enabled     -D glvnd=enabled     -D glx=dri     -D libunwind=enabled     -D llvm=enabled     -D lmsensors=disabled     -D microsoft-clc=disabled     -D platforms=x11,wayland     -D valgrind=disabled     -D video-codecs=all     -D vulkan-drivers=amd,intel,intel_hasvk,swrast,virtio,nouveau     -D vulkan-layers=device-select,intel-nullhw,overlay     -D tools=[]     -D zstd=enabled     -D buildtype=plain     -D prefix=/usr     -D sysconfdir=/etc     -D legacy-x11=dri2     --wrap-mode=nofallback     --force-fallback-for=syn,paste,rustc-hash ; cat /mesa/_build/meson-logs/meson-log.txt && exit 1 && meson configure --no-pager _build && ninja -C _build
-#15 CANCELED
-ERROR: failed to build: failed to solve: Canceled: context canceled

tools/ci/amd64/clang/coverage.sh

@@ -1,29 +1,37 @@
 #!/bin/bash
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
+
+CC=$(which clang)
+export CC
+
+CXX=$(which clang++)
+export CXX
+
+DISPLAY=:99
+export DISPLAY
 
 Xvfb :99 -screen 0 1024x768x16 &
-export CXX=$(which clang++)
-export CC=$(which clang)
-export DISPLAY=:99
 
-cmake . \
-    -Bbuild \
-    -GNinja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DENABLE_LLVM_COVERAGE=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++ -g -fno-omit-frame-pointer" &&
-    cmake --build ./build -j $(nproc)
+cmake \
+    -S . \
+    -B build \
+    -G Ninja \
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D ENABLE_LLVM_COVERAGE=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++ -g -fno-omit-frame-pointer"
+
+cmake --build ./build -j"$(nproc)"
 
 mkdir -p ./build/coverage/
-for test in $(find ./build -type f -name '*_tests' -executable); do
-    export LLVM_PROFILE_FILE="./build/coverage/$(basename "$(dirname "$test")").profraw"
-    echo ${LLVM_PROFILE_FILE} >>./build/coverage/list
+while IFS= read -r -d '' test; do
+    LLVM_PROFILE_FILE="./build/coverage/$(basename "$(dirname "$test")").profraw"
+    export LLVM_PROFILE_FILE
 
+    echo "${LLVM_PROFILE_FILE}" >>./build/coverage/list
     gdb \
         --return-child-result \
         -ex='set confirm off' \
@@ -33,7 +41,7 @@ for test in $(find ./build -type f -name '*_tests' -executable); do
         -ex='quit' \
         -q \
         "$test"
-done
+done < <(find ./build -type f -name '*_tests' -executable -print0)
 
 llvm-profdata merge --input-files './build/coverage/list' -o "./build/coverage/merged.profdata"
 find ./build/modules -type f -name "*.profraw" -exec rm -fv {} +
@@ -41,8 +49,8 @@ find ./build/modules -type f -name "*.profraw" -exec rm -fv {} +
 LLVM_COV_SHOW=$(
     llvm-cov show \
         -instr-profile='./build/coverage/merged.profdata' \
-        $(find ./build -type f -name '*_tests' -executable -exec printf -- '-object %s ' {} \;) \
-        $(find ./build -type f -name '*\.a' -exec printf -- '-object %s ' {} \;) \
+        "$(find ./build -type f -name '*_tests' -executable -exec printf -- '-object %s ' {} \;)" \
+        "$(find ./build -type f -name '*\.a' -exec printf -- '-object %s ' {} \;)" \
         -ignore-filename-regex='\.test\.cpp$' \
         -ignore-filename-regex='\.fuzz\.cpp$'
 )

tools/ci/amd64/clang/lsan.sh

@@ -1,21 +1,33 @@
 #!/bin/bash
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
+
+CC=$(which clang)
+export CC
+
+CXX=$(which clang++)
+export CXX
+
+DISPLAY=:99
+export DISPLAY
+
+LSAN_OPTIONS="suppressions=$(git rev-parse --show-toplevel)/tools/ci/amd64/clang/lsan.supp:fast_unwind_on_malloc=0:verbosity=1:report_objects=1"
+export LSAN_OPTIONS
+
+LSAN_SYMBOLIZER_PATH="$(which llvm-symbolizer)"
+export LSAN_SYMBOLIZER_PATH
 
 Xvfb :99 -screen 0 1024x768x16 &
-export CXX=$(which clang++)
-export CC=$(which clang)
-export DISPLAY=:99
 
-cmake . \
-    -Bbuild \
-    -GNinja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DCMAKE_BUILD_TYPE=Debug \
-    -DCMAKE_CXX_FLAGS=" \
+cmake \
+    -S . \
+    -B build \
+    -G Ninja \
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS=" \
 -fsanitize=leak \
 -fno-common \
 -g \
@@ -23,17 +35,16 @@ cmake . \
 -std=c++23 \
 -nostdinc++ \
 -isystem /libcxx_lsan/include/c++/v1/" \
-    -DCMAKE_EXE_LINKER_FLAGS=" \
+    -D CMAKE_EXE_LINKER_FLAGS=" \
 -fsanitize=leak \
 -L/libcxx_lsan/lib \
 -lc++ \
 -lc++abi \
--Wl,-rpath,/libcxx_lsan/lib" &&
-    cmake --build ./build --target='renderer_tests' -j$(nproc)
+-Wl,-rpath,/libcxx_lsan/lib"
 
-export LSAN_OPTIONS="suppressions=$(git rev-parse --show-toplevel)/tools/ci/amd64/clang/lsan.supp:fast_unwind_on_malloc=0:verbosity=1:report_objects=1"
-export LSAN_SYMBOLIZER_PATH="$(which llvm-symbolizer)"
-for test in $(find ./build -type f -name '*_tests' -executable); do
+cmake --build ./build --target='renderer_tests' -j"$(nproc)"
+
+while IFS= read -r -d '' test; do
     echo "Running $test"
     "$test"
-done
+done < <(find ./build -type f -name '*_tests' -executable -print0)

tools/ci/amd64/clang/msan.sh

@@ -1,21 +1,27 @@
 #!/bin/bash
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
+
+CC=$(which clang)
+export CC
+
+CXX=$(which clang++)
+export CXX
+
+DISPLAY=:99
+export DISPLAY
 
 Xvfb :99 -screen 0 1024x768x16 &
-export CXX=$(which clang++)
-export CC=$(which clang)
-export DISPLAY=:99
 
-cmake . \
-    -Bbuild \
-    -GNinja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_CXX_FLAGS=" \
+cmake \
+    -S . \
+    -B build \
+    -G Ninja \
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS=" \
 -fsanitize=memory \
 -fsanitize-memory-track-origins \
 -g \
@@ -23,16 +29,17 @@ cmake . \
 -std=c++23 \
 -nostdinc++ \
 -isystem /libcxx_msan/include/c++/v1/" \
-    -DCMAKE_EXE_LINKER_FLAGS=" \
+    -D CMAKE_EXE_LINKER_FLAGS=" \
 -fsanitize=memory \
 -fsanitize-memory-track-origins \
 -L/libcxx_msan/lib \
 -lc++ \
 -lc++abi \
--Wl,-rpath,/libcxx_msan/lib" &&
-    cmake --build ./build -j$(nproc)
+-Wl,-rpath,/libcxx_msan/lib"
 
-for test in $(find ./build -type f -name '*_tests' -executable); do
+cmake --build ./build -j"$(nproc)"
+
+while IFS= read -r -d '' test; do
     echo "Running $test"
     "$test"
-done
+done < <(find ./build -type f -name '*_tests' -executable -print0)

tools/ci/amd64/gcc/unit_tests.sh

@@ -1,25 +1,32 @@
 #!/bin/bash
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
+
+CC=$(which gcc)
+export CC
+
+CXX=$(which g++)
+export CXX
+
+DISPLAY=:99
+export DISPLAY
 
 Xvfb :99 -screen 0 1024x768x16 &
-export CXX=$(which g++)
-export CC=$(which gcc)
-export DISPLAY=:99
 
 # gcc uses libstdc++ by default
-cmake . \
-    -Bbuild \
-    -GNinja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_CXX_FLAGS="-std=c++23 -g -fno-omit-frame-pointer" &&
-    cmake --build ./build -j $(nproc)
+cmake \
+    -S . \
+    -B build \
+    -G Ninja \
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS="-std=c++23 -g -fno-omit-frame-pointer"
 
-for test in $(find ./build -type f -name '*_tests' -executable); do
+cmake --build ./build -j"$(nproc)"
+
+while IFS= read -r -d '' test; do
     echo "Running $test"
     gdb \
         --return-child-result \
@@ -30,4 +37,5 @@ for test in $(find ./build -type f -name '*_tests' -executable); do
         -ex='quit' \
         -q \
         "$test"
-done
+
+done < <(find ./build -type f -name '*_tests' -executable -print0)

tools/ci/amd64/gcc/valgrind.sh

@@ -1,28 +1,37 @@
 #!/bin/bash
 
-export DEBUGINFOD_URLS="https://debuginfod.archlinux.org/"
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/
+CC=$(which gcc)
+export CC
+
+CXX=$(which g++)
+export CXX
+
+DISPLAY=:99
+export DISPLAY
+
+DEBUGINFOD_URLS="https://debuginfod.archlinux.org/"
+export DEBUGINFOD_URLS
 
 Xvfb :99 -screen 0 1024x768x16 &
-export CXX=$(which g++)
-export CC=$(which gcc)
-export DISPLAY=:99
 
 # gcc uses libstdc++ by default
-cmake . \
-    -Bbuild \
-    -GNinja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_CXX_FLAGS="-std=c++23 -fno-omit-frame-pointer -fno-common -g" &&
-    cmake --build ./build -j $(nproc)
+cmake \
+    -S . \
+    -B build \
+    -G Ninja \
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS="-std=c++23 -fno-omit-frame-pointer -fno-common -g"
 
-for test in $(find ./build -type f -name '*_tests' -executable); do
+cmake --build ./build -j"$(nproc)"
+
+while IFS= read -r -d '' test; do
     echo "Running $test"
+
     valgrind \
         --leak-check=full \
         --show-leak-kinds=all \
@@ -31,5 +40,6 @@ for test in $(find ./build -type f -name '*_tests' -executable); do
         --num-callers=50 \
         --gen-suppressions=all \
         --suppressions='./tools/ci/amd64/gcc/valgrind.supp' \
-        --error-exitcode=255 ${test} || exit 1
-done
+        --error-exitcode=255 "${test}" || exit 1
+
+done < <(find ./build -type f -name '*_tests' -executable -print0)

tools/ci/static_analysis/clang_format.sh

@@ -4,7 +4,6 @@ set -euo pipefail
 cd "$(git rev-parse --show-toplevel)/"
 
 has_fomatting_issues=0
-
 while IFS= read -r -d '' file; do
     echo "Checking format for $file"
 
@@ -17,5 +16,4 @@ done < <(find ./modules -name '*.?pp' -print0)
 if [ "$has_fomatting_issues" -eq 0 ]; then
     echo "✅ All files are properly formatted! Well done! ^~^"
 fi
-
 exit ${has_fomatting_issues}

tools/ci/static_analysis/clang_tidy.sh

@@ -1,18 +1,22 @@
 #!/bin/bash
 
-set -e
-cd $(git rev-parse --show-toplevel)/
-rm -rf ./build && mkdir build/ && cd build
+set -euo pipefail
+cd "$(git rev-parse --show-toplevel)/"
 
-export CC=$(which clang)
+CC=$(which clang)
+export CC
 
-export CXX=$(which clang++)
+CXX=$(which clang++)
+export CXX
 
-cmake .. \
+cmake \
+    -S . \
+    -B build \
     -G Ninja \
-    -DCMAKE_LINKER_TYPE=MOLD \
-    -DENABLE_UNIT_TESTS=ON \
-    -DENABLE_STATIC_ANALYSIS=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++" &&
-    cmake --build . -j $(nproc)
+    -D CMAKE_LINKER_TYPE=MOLD \
+    -D ENABLE_UNIT_TESTS=ON \
+    -D ENABLE_STATIC_ANALYSIS=ON \
+    -D CMAKE_BUILD_TYPE=Release \
+    -D CMAKE_CXX_FLAGS="-std=c++23 -stdlib=libc++"
+
+cmake --build . -j"$(nproc)"

tools/ci/static_analysis/cmake_format.sh

@@ -16,5 +16,4 @@ done < <(find ./modules ./tools/cmake -type f \( -name 'CMakeLists.txt' -o -name
 if [ "$has_formatting_issues" -ne 0 ]; then
     echo "✅ All files are properly formatted! Well done! ^~^"
 fi
-
 exit ${has_formatting_issues}

tools/ci/static_analysis/shell_format.sh

@@ -4,7 +4,6 @@ set -euo pipefail
 cd "$(git rev-parse --show-toplevel)/"
 
 has_fomatting_issues=0
-
 while IFS= read -r -d '' file; do
     echo "Checking format for $file"
 
@@ -17,5 +16,4 @@ done < <(find ./modules ./tools -name '*.sh' -print0)
 if [ "$has_fomatting_issues" -eq 0 ]; then
     echo "✅ All files are properly formatted! Well done! ^~^"
 fi
-
 exit ${has_fomatting_issues}