From 2061fc74c202c39ed31fd38b26dca961a470fade Mon Sep 17 00:00:00 2001 From: light7734 Date: Fri, 19 Sep 2025 09:44:12 +0330 Subject: [PATCH] chore: remove lz4 as dependency --- conanfile.py | 1 - modules/asset_parser/CMakeLists.txt | 1 - modules/asset_parser/private/assets/text.cpp | 1 - .../asset_parser/private/assets/texture.cpp | 1 - modules/asset_parser/private/parser.cpp | 57 ------------------- tools/cmake/dependencies.cmake | 1 - 6 files changed, 62 deletions(-) diff --git a/conanfile.py b/conanfile.py index 0c9ccfc..92c90ef 100644 --- a/conanfile.py +++ b/conanfile.py @@ -30,7 +30,6 @@ class LightRecipe(ConanFile): def requirements(self): self.requires("entt/3.15.0") - self.requires("lz4/1.10.0") def layout(self): cmake_layout(self) diff --git a/modules/asset_parser/CMakeLists.txt b/modules/asset_parser/CMakeLists.txt index 4ebd2a8..4625172 100644 --- a/modules/asset_parser/CMakeLists.txt +++ b/modules/asset_parser/CMakeLists.txt @@ -6,6 +6,5 @@ add_library_module(asset_parser target_link_libraries( asset_parser - PRIVATE LZ4::lz4_static PRIVATE logger ) diff --git a/modules/asset_parser/private/assets/text.cpp b/modules/asset_parser/private/assets/text.cpp index de31041..cb990a6 100644 --- a/modules/asset_parser/private/assets/text.cpp +++ b/modules/asset_parser/private/assets/text.cpp @@ -1,5 +1,4 @@ #include -#include namespace Assets { diff --git a/modules/asset_parser/private/assets/texture.cpp b/modules/asset_parser/private/assets/texture.cpp index 97b8012..3188a37 100644 --- a/modules/asset_parser/private/assets/texture.cpp +++ b/modules/asset_parser/private/assets/texture.cpp @@ -1,5 +1,4 @@ #include -#include namespace Assets { diff --git a/modules/asset_parser/private/parser.cpp b/modules/asset_parser/private/parser.cpp index 903ce81..4511740 100644 --- a/modules/asset_parser/private/parser.cpp +++ b/modules/asset_parser/private/parser.cpp @@ -1,62 +1,5 @@ #include -#include -#include -#include namespace Assets { -// void Asset::unpack(std::byte *destination) -// { -// if (!m_stream.is_open()) -// { -// throw std::logic_error { -// "Failed to unpack asset: " -// "ifstream is closed", -// }; -// } -// -// switch (m_metadata.blob_compression_type) -// { -// case CompressionType::None: -// if (m_metadata.packed_size != m_metadata.unpacked_size) -// { -// throw std::logic_error { -// "Failed to unpack asset: " -// "compression type set to none but packed/unpacked sizes differ", -// }; -// } -// -// m_stream.read( -// std::bit_cast(destination), -// static_cast(m_metadata.packed_size) -// ); -// m_stream.close(); -// -// case CompressionType::LZ4: -// m_stream.close(); -// throw std::logic_error { -// "Failed to unpack asset: " -// "LZ4 compression is not implemented yet", -// }; -// -// -// case CompressionType::LZ4HC: -// m_stream.close(); -// throw std::logic_error { -// "Failed to unpack asset: " -// "LZ4HC compression is not implemented yet", -// }; -// -// default: -// m_stream.close(); -// throw std::logic_error { -// std::format( -// "Failed to unpack asset: " -// "Compression type was not recognized: {}", -// std::to_underlying(m_metadata.blob_compression_type) -// ), -// }; -// } -// } - } // namespace Assets diff --git a/tools/cmake/dependencies.cmake b/tools/cmake/dependencies.cmake index 92be1ef..1b961a9 100644 --- a/tools/cmake/dependencies.cmake +++ b/tools/cmake/dependencies.cmake @@ -1,2 +1 @@ find_package(EnTT REQUIRED) -find_package(lz4 REQUIRED)